fixed for Julia v0.7 #329
fixed for Julia v0.7 #329
Conversation
fredrikekre
force-pushed
the
fe/0.7
branch
2 times, most recently
from
3f5eb9a to
297fa17
Compare
|
Great; all green! Some things to note:
Would be great to get this merged and tagged, to make ForwardDiff pass Keno's new pkgeval! |
|
Perhaps a few more |
|
Those are JuliaDiff/DiffTests.jl#3 |
🎉indeed! Thanks for this. |
.travis.yml
Outdated
| - julia: nightly | ||
| # matrix: | ||
| # allow_failures: | ||
| # - julia: nightly | ||
| notifications: |
There was a problem hiding this comment.
It might be better to do:
julia:
- 0.7
- nightly
matrix:
allow_failures:
- julia: nightly
I think the next release of ForwardDiff should be v0.7 only. We can backport future fixes to previous minor releases if needed. Trying to maintain a single codebase to support two separate Julia versions isn't worth it IMO.
There was a problem hiding this comment.
See comments here: JuliaDiff/DiffTests.jl#3 (comment)
Arguably nightly is more important to test at this stage compared to - 0.7 which is 0.7-beta
There was a problem hiding this comment.
If a contributor makes a PR which passes 0.7 but not nightly, I'd merge it regardless, since I don't pass/fail that contributor's work based on unreleased/changing upstream behavior.
Downstream package CI really should not depend on unfixed upstream dependencies. If an upstream tool wants downstream tools to update, upstream can post new tags for the 0.7 target, and downstream can update accordingly.
Note that the allowing failures in the build matrix still runs the tests, so we can still keep our eye on it.
There was a problem hiding this comment.
Guess we have to wait for rc-1 then.
|
As mentioned in the other comment, I think we just drop v0.6 support on ForwardDiff master with this PR. Obviously the existing ForwardDiff release can continue to be supported via backports if needed. |
|
Okay, I will update the PR and eliminate 0.6 stuff. |
fredrikekre
force-pushed
the
fe/0.7
branch
3 times, most recently
from
8851a55 to
27ac571
Compare
- bump Julia requirement to 0.7-beta - update Travis and AppVeyor scripts - remove usage of Compat - misc other Julia 0.7 changes
|
Now passes on |
|
bump |
|
Thanks again! |
No description provided.