Skip to content

fixes for Julia v0.7 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2018
Merged

fixes for Julia v0.7 #3

merged 1 commit into from
Jul 19, 2018

Conversation

fredrikekre
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jul 3, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 163461a on fredrikekre:fe/0.7 into df96c3c on JuliaDiff:master.

@fredrikekre
Copy link
Contributor Author

Is this OK or is it worth the trouble to keep this compatible with 0.6?

.travis.yml Outdated
- julia: nightly
# matrix:
# allow_failures:
# - julia: nightly
notifications:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave this uncommented.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? nightly is closer to v0.7.0 than v0.7-beta (which the 0.7 travis target points to).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, -nightly and -0.7 are the same right now for Travis?

I feel that's it bad form to predicate CI pass/fail on unfixed upstream dependencies, since you can't really expect contributors to update the package for every new upstream commit. In contrast, fixing the upstream dependency to a specific tag (v0.7-beta, v0.7-rc, etc.) is a clear specification of what contributors intend to support, such that upgrading requires explicit intervention/testing.

But if -0.7 is actually targeting -nightly then that whole philosophy falls through I guess 😛

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, regardless, if indeed -0.7 targets the same commits as -nightly, it should still be fine to uncomment nightly as an allowed failure in the build matrix, since the same failures would still be captured for the 0.7 runs (assuming I understand Travis' build system correctly).

Copy link
Contributor Author

@fredrikekre fredrikekre Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- 0.7 points to the latest release of the 0.7 series, which currently is 0.7-beta, but soon will be 0.7-rc1 or w/e so it is not the same as nightly which is the front of julia master.
Reason for commenting out - 0.7 here is that StaticArrays is broken since it includes the Statistics stdlib as a dependency (my fault 😛) but that stdlib is not in the beta release, it was merged some commits after. That was the ForwardDiff PR.

@fredrikekre fredrikekre force-pushed the fe/0.7 branch 2 times, most recently from 7107f20 to 40f83cd Compare July 15, 2018 18:34
@fredrikekre
Copy link
Contributor Author

Now passes on nightly and 0.7-beta2.

@fredrikekre
Copy link
Contributor Author

bump

@jrevels jrevels merged commit 05b8721 into JuliaDiff:master Jul 19, 2018
@jrevels
Copy link
Member

jrevels commented Jul 19, 2018

Thanks again!

@fredrikekre fredrikekre deleted the fe/0.7 branch July 19, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants