-
Notifications
You must be signed in to change notification settings - Fork 10
fixes for Julia v0.7 #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is this OK or is it worth the trouble to keep this compatible with 0.6? |
.travis.yml
Outdated
- julia: nightly | ||
# matrix: | ||
# allow_failures: | ||
# - julia: nightly | ||
notifications: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave this uncommented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? nightly
is closer to v0.7.0
than v0.7-beta
(which the 0.7 travis target points to).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, -nightly
and -0.7
are the same right now for Travis?
I feel that's it bad form to predicate CI pass/fail on unfixed upstream dependencies, since you can't really expect contributors to update the package for every new upstream commit. In contrast, fixing the upstream dependency to a specific tag (v0.7-beta
, v0.7-rc
, etc.) is a clear specification of what contributors intend to support, such that upgrading requires explicit intervention/testing.
But if -0.7
is actually targeting -nightly
then that whole philosophy falls through I guess 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, regardless, if indeed -0.7
targets the same commits as -nightly
, it should still be fine to uncomment nightly
as an allowed failure in the build matrix, since the same failures would still be captured for the 0.7
runs (assuming I understand Travis' build system correctly).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 0.7
points to the latest release of the 0.7 series, which currently is 0.7-beta
, but soon will be 0.7-rc1
or w/e so it is not the same as nightly
which is the front of julia master.
Reason for commenting out That was the ForwardDiff PR.- 0.7
here is that StaticArrays is broken since it includes the Statistics
stdlib as a dependency (my fault 😛) but that stdlib is not in the beta release, it was merged some commits after.
7107f20
to
40f83cd
Compare
Now passes on |
bump |
Thanks again! |
No description provided.