Remove eval called by rrule_test #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything else this PR needs? |
|
sorry its been weekend+public holidays here since it was openned. |
Co-authored-by: Matt.jl <matt.brzezinski@invenia.ca>
|
I am going to leave this to @mattBrzezinski to review and follow up til merged. |
mattBrzezinski
approved these changes
May 11, 2020
Co-authored-by: Matt.jl <matt.brzezinski@invenia.ca>
|
Thanks! Implemented the requested changes. |
nickrobinson251
added
the
needs version bump
nickrobinson251
approved these changes
May 12, 2020
There was a problem hiding this comment.
LGTM. Thanks! A other couple tiny comments which you're free to ignore.
Before we merge, please can you bumpy the version number?
I know it's an internal-only change, but good to release this change by itself and not with other changes in case we do hit any unexpected issues
Co-authored-by: Nick Robinson <npr251@gmail.com>
|
Done! |
nickrobinson251
removed
the
needs version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #30 by removing the "terrifying"
evalin_make_fdm_call.