Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing functions with symbols as arguments #30

Closed
sethaxen opened this issue May 1, 2020 · 1 comment · Fixed by #32
Closed

Testing functions with symbols as arguments #30

sethaxen opened this issue May 1, 2020 · 1 comment · Fixed by #32

Comments

@sethaxen
Copy link
Member

sethaxen commented May 1, 2020

This came up in JuliaDiff/ChainRules.jl#182, where rrule_test fails because one of the args equals :U. _make_fdm_call seems to evaluate that argument as a variable U, which does not exist.
@oxinabox
Copy link
Member

oxinabox commented May 1, 2020

Yeah, we need to get rid of the eval from there.

It's terrifying.

I found a note somewhere explaining why that was done. I think it was working around awkwardness in FiniteDifferences.jl

@sethaxen sethaxen mentioned this issue May 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove eval called by rrule_test sethaxen/ChainRulesTestUtils.jl
2 participants
@oxinabox @sethaxen