Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rrule for map #314

Open
CarloLucibello opened this issue Dec 1, 2020 · 5 comments · May be fixed by #671
Open

rrule for map #314

CarloLucibello opened this issue Dec 1, 2020 · 5 comments · May be fixed by #671
Labels
missing rule

Comments

@CarloLucibello
Copy link
Contributor

There used to be a rrule for map, introduced here #56, but I can't find it anymore.

Related to FluxML/Zygote.jl#842
@gxyd
Copy link
Contributor

gxyd commented Dec 1, 2020 •
edited
Loading

Using git bisect I can see that it was removed from system in commit: 02e7857

@simeonschaub
Copy link
Member

See JuliaDiff/ChainRulesCore.jl#68, we currently lack a proper way for rrules to call back into the AD system, so ChainRules can't really deal with higher-order functions yet.

@nickrobinson251
Copy link
Contributor

Xref #222

@nickrobinson251 nickrobinson251 added blocked Can't be merged til something is resolved in another PR or issue missing rule labels Dec 1, 2020
@oxinabox
Copy link
Member

oxinabox commented Dec 1, 2020

#222 is the version of this that we can without doing JuliaDiff/ChainRulesCore.jl#68 first.

@mcabbott mcabbott mentioned this issue Dec 6, 2020
Closed
@mzgubic mzgubic removed the blocked Can't be merged til something is resolved in another PR or issue label Jun 22, 2021
@mzgubic
Copy link
Member

mzgubic commented Jun 22, 2021

No longer blocked as of JuliaDiff/ChainRulesCore.jl#363

@ToucheSir ToucheSir mentioned this issue May 9, 2022
Open
@mcabbott mcabbott linked a pull request Oct 20, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
missing rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rules for map, zip and some comprehensions mcabbott/ChainRules.jl
6 participants
@oxinabox @simeonschaub @CarloLucibello @gxyd @nickrobinson251 @mzgubic