Add rrule for map and expand the testing framework #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
commented
Jun 17, 2019
ararslan
commented
Jun 17, 2019
ararslan
commented
Jun 17, 2019
| @@ -50,23 +50,58 @@ function rrule_test(f, ȳ, (x, x̄)::Tuple{Any, Any}; rtol=1e-9, atol=1e-9, fdm | |||
| test_accumulation(Zero(), dx, ȳ, x̄_ad) | |||
| end | |||
|
|
|||
| function _make_fdm_call(fdm, f, ȳ, xs, ignores) | |||
There was a problem hiding this comment.
Eventually what this function does should be moved to FDM, but it took less time to write this than it would to figure out how to incorporate it into the FDM framework directly.
jrevels
reviewed
Jun 17, 2019
This implements `rrule(map, f, xs...)` and expands `rrule_test` to allow non-differentiable arguments. For such cases, the user need only pass `nothing` as the argument's assumed sensitivity.
|
In the interest of time and getting more stuff moved over from Nabla, I'm going to go ahead with this since it passes tests and is (now) pretty straightforward, plus nothing yet depends on ChainRules. Please feel free to open an issue about anything added here. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
rrule(map, f, xs...)and expandsrrule_testto allow non-differentiable arguments. For such cases, the user need only passnothingas the argument's assumed sensitivity.Therruleformapis admittedly a little bizarre looking. It was ported from Nabla and attempts to use the same logic but stuffed awkwardly into the ChainRules framework.rruleformaprequires that the mapped function have anrruledefined for it.