Skip to content

Improve file/line attribution for macros #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Conversation

timholy
Copy link
Member

@timholy timholy commented Dec 6, 2021

This makes it easier to identify the caller of a macro.
This fixes a test failure on nightly.

xref #498

This makes it easier to identify the caller of a macro.
This fixes a test failure on nightly.
@timholy timholy changed the title Teh/line_numbers_macros Improve file/line attribution for macros Dec 6, 2021
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #500 (48ad4db) into master (398721d) will decrease coverage by 0.78%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
- Coverage   86.91%   86.13%   -0.79%     
==========================================
  Files          12       12              
  Lines        2362     2394      +32     
==========================================
+ Hits         2053     2062       +9     
- Misses        309      332      +23     
Impacted Files Coverage Δ
src/utils.jl 86.02% <100.00%> (-0.73%) ⬇️
src/interpret.jl 83.41% <0.00%> (-3.20%) ⬇️
src/types.jl 73.68% <0.00%> (-0.65%) ⬇️
src/breakpoints.jl 94.85% <0.00%> (-0.52%) ⬇️
src/optimize.jl 97.39% <0.00%> (-0.31%) ⬇️
src/commands.jl 93.06% <0.00%> (+0.08%) ⬆️
src/construct.jl 91.07% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 398721d...48ad4db. Read the comment docs.

@aviatesk
Copy link
Member

aviatesk commented Dec 6, 2021

Hm, but this PR seems to cause a failure in v1.0 CI. I'd like to drop the support anyway, so I'm just fine to merge this as is.

@timholy
Copy link
Member Author

timholy commented Dec 6, 2021

In this case, this change ended up fixing a failure on older Julia versions, and we were effectively doing a @test_broken. Nice when it works out that way.

@timholy timholy merged commit f365bcd into master Dec 6, 2021
@timholy timholy deleted the teh/line_numbers_macros branch December 6, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants