-
Notifications
You must be signed in to change notification settings - Fork 37
update LTS version, drop v1.0 support #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
==========================================
- Coverage 86.73% 82.76% -3.97%
==========================================
Files 12 12
Lines 2488 2443 -45
==========================================
- Hits 2158 2022 -136
- Misses 330 421 +91
Continue to review full report at Codecov.
|
Will need to update the Julia compat as well as the minor version |
FWIW, I'd kinda like to keep 1.0 compat for the VS Code extension. |
VSCode could just still use JuliaInterpreter 0.8.21 on 1.0? Or is the worry that future features won't be available? |
We're currently vendoring and side-loading all packages. Shipping multiple versions of a package would be feasible but fairly annoying. |
It's painful to try to keep v1.0 compat imho mostly because this package heavily interacts with Julia internals, as we just see yet another example at #500 (comment). |
Alright, |
701a99e
to
2231cda
Compare
@timholy @pfitzseb @KristofferC Can we tag 0.9? It's quite big change, but since it is a minor bump, it shouldn't break any existing system and I think we can gradually update dependents in the ecosystem. |
Let's live on the cutting edge :)