Skip to content

update LTS version, drop v1.0 support #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2021
Merged

update LTS version, drop v1.0 support #499

merged 2 commits into from
Dec 8, 2021

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented Dec 5, 2021

Let's live on the cutting edge :)

@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #499 (988d98b) into master (716d7f6) will decrease coverage by 3.96%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
- Coverage   86.73%   82.76%   -3.97%     
==========================================
  Files          12       12              
  Lines        2488     2443      -45     
==========================================
- Hits         2158     2022     -136     
- Misses        330      421      +91     
Impacted Files Coverage Δ
src/precompile.jl 0.00% <0.00%> (ø)
src/construct.jl 89.49% <50.00%> (-1.78%) ⬇️
src/utils.jl 84.86% <91.66%> (-1.21%) ⬇️
src/commands.jl 92.91% <100.00%> (-0.42%) ⬇️
src/interpret.jl 71.98% <100.00%> (-13.58%) ⬇️
src/optimize.jl 96.92% <100.00%> (-0.62%) ⬇️
src/packagedef.jl 86.95% <100.00%> (-4.54%) ⬇️
src/types.jl 73.24% <100.00%> (-1.28%) ⬇️
src/builtins.jl 68.52% <0.00%> (-8.13%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 716d7f6...988d98b. Read the comment docs.

@simeonschaub
Copy link
Collaborator

Will need to update the Julia compat as well as the minor version

@pfitzseb
Copy link
Member

pfitzseb commented Dec 6, 2021

FWIW, I'd kinda like to keep 1.0 compat for the VS Code extension.
It's not super important though since I suppose we can disable some features for old Julia versions.

@KristofferC
Copy link
Member

VSCode could just still use JuliaInterpreter 0.8.21 on 1.0? Or is the worry that future features won't be available?

@pfitzseb
Copy link
Member

pfitzseb commented Dec 6, 2021

We're currently vendoring and side-loading all packages. Shipping multiple versions of a package would be feasible but fairly annoying.
Then again, only supporting a debugger on LTS and newer doesn't seem too bad.

@aviatesk
Copy link
Member Author

aviatesk commented Dec 6, 2021

It's painful to try to keep v1.0 compat imho mostly because this package heavily interacts with Julia internals, as we just see yet another example at #500 (comment).
So I'd like to ask you to drop the debugger support for older Julia versions.

@pfitzseb
Copy link
Member

pfitzseb commented Dec 6, 2021

Alright, :shipit: :)

Base automatically changed from sds/fix_cov_test to master December 6, 2021 14:19
@pfitzseb pfitzseb mentioned this pull request Dec 8, 2021
@pfitzseb pfitzseb merged commit 10fd8fc into master Dec 8, 2021
@aviatesk aviatesk deleted the avi/lts branch December 16, 2021 11:54
@aviatesk
Copy link
Member Author

@timholy @pfitzseb @KristofferC Can we tag 0.9? It's quite big change, but since it is a minor bump, it shouldn't break any existing system and I think we can gradually update dependents in the ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants