-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make eachcol default to false #1613
Conversation
@nalimilan |
This looks good to me, but I'm not sure we should merge it right now since it will break code that hasn't been ported yet, and there's no hurry to change this: old code that used |
OK - let us put it on hold. I will keep it open to remember what has to be changed. How releases would you wait with fixing this? |
Not sure, but I would at least make a release removing the indexing deprecations first, so that people can upgrade without too many changes to silence them. |
Do we want to finish the deprecation for |
@nalimilan - I think that enough time has passed for the deprecation. If you are OK to merge it now I will review this PR to make sure and make it ready for merging. |
Fine with me. |
This cleans up deprecations and respects JuliaLang/julia#29749.
It would not hurt if someone checked if I had put right Julia version in the condition. Thanks!