-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nrow/ncol #406
Comments
So how will loop code look like?
|
btw, the vi code to replace :%s/nrow(\(\w\+\))/size(\1)[1] So I suppose I'll start migrating over sooner rather than later. |
You should use |
Okay, that's better. :%s/nrow(\(\w\+\))/size(\1, 1) |
I'm surprised this hasn't been done in the past 3 years since this issue was brought up. I definitely agree that we should be using |
I'm not sure about this. I don't think it is a good idea to make I should explain what I mean by better here. If a DataFrame is too similar to an array then users might start to use in the same way and that would give a bad experience with slow execution and uninferred return values. |
Hm, that's a very good point. |
OTOH, |
nrow and ncol will be very familiar to people coming from R, who are likely Pete Peter M. Haverty, Ph.D. On Thu, Aug 18, 2016 at 8:11 AM, Milan Bouchet-Valat <
|
@phaverty While we certainly take it into account, the fact that something exists in a language is never a sufficient argument by itself for including something in Julia. The most important question is whether it makes for a good and consistent design in Julia. |
|
I'm not a fan of |
+1 for Jacob's proposal. Adding new names seems superfluous. |
I'd be fine with that as well. |
Also not in favor af new names at this point. Just because ncol/nrow are used in R doesn't mean we have to be different. I prefer it slightly to size because it is more natural to a table vs array interface. |
I think @nalimilan is right that |
If this change is part of focusing on tables, should this really be part of the API at all? Computing |
^ that's a good point John. Currently in DataStreams for a |
Is that a requirement? |
I don't know. It might be surprising to people if, say, the REPL blocked for a long time when you run |
I'm also not sure. My gut feeling is that it's okay that the costs are higher for this operation but I think it's useful to include such large examples in the API discussion. |
We should still deprecate |
Adding to milestone before we forget since that's easy to do. |
I just bumped into a previous discussion from... 2013: |
+1 in favor of |
from that 2013 discussion, reminder for this issue that |
I am closing this as my feeling is that after the discussions
Feel free to reopen it if you disagree (I just want to clean up pending issues where I feel a conclusion was reached). |
I support @bkamins here. |
#i'mwithbogamil |
We should remove
nrow
andncol
. Everything should be done withsize(df)
.The text was updated successfully, but these errors were encountered: