fix deprecated array constructors #348

fredrikekre · 2017-12-01T08:03:41Z

No description provided.

fredrikekre · 2017-12-01T08:41:39Z

Waiting for JuliaLang/METADATA.jl#12295

fredrikekre · 2017-12-01T10:03:08Z

This will fail because of JuliaLang/Compat.jl#416 (comment)

fredrikekre · 2017-12-02T16:18:58Z

Well, tests pass on 0.6 now, but KeyIterator has changed to KeySet on master...

codecov · 2017-12-02T16:34:52Z

Codecov Report

Merging #348 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #348      +/-   ##
=========================================
+ Coverage   96.45%   96.5%   +0.04%     
=========================================
  Files          31      31              
  Lines        2286    2287       +1     
=========================================
+ Hits         2205    2207       +2     
+ Misses         81      80       -1

Impacted Files	Coverage Δ
src/sorted_dict.jl	`98.31% <ø> (ø)`	⬆️
src/delegate.jl	`40% <ø> (ø)`	⬆️
src/sorted_multi_dict.jl	`92.92% <ø> (ø)`	⬆️
src/DataStructures.jl	`100% <ø> (+11.11%)`	⬆️
src/classified_collections.jl	`85.71% <100%> (ø)`	⬆️
src/priorityqueue.jl	`99.13% <100%> (ø)`	⬆️
src/int_set.jl	`100% <100%> (ø)`	⬆️
src/balanced_tree.jl	`100% <100%> (ø)`	⬆️
src/circ_deque.jl	`100% <100%> (ø)`	⬆️
src/heaps.jl	`100% <100%> (ø)`	⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aa166e...ef72847. Read the comment docs.

oxinabox · 2017-12-06T07:34:19Z

Needs to be rebased as of #349 which is a rough subset of these changes.
(My bad, I though that this was blocked waiting for #349, not that they directly overlapped)

martinholters · 2017-12-06T08:28:58Z

Ooops, yes, sorry, I had missed that you had updated this PR, too.

martinholters · 2017-12-06T08:30:27Z

src/DataStructures.jl

+    @static if VERSION < v"0.7.0-DEV.2437"
+        _include_string(str) = eval(parse(str))
+    else
+        _include_string(str) = eval(Meta.parse(str))


I think this can be used unconditionally, because Meta.parse is available on 0.6, too.

fredrikekre · 2017-12-06T09:49:28Z

Rebased and removed the KeySet stuff from this PR.

oxinabox

Nothing looks egregious.

oxinabox · 2017-12-06T09:55:15Z

src/ordered_dict.jl

-_oldOrderedDict1 = "OrderedDict{V}(kv::Tuple{Vararg{Pair{TypeVar(:K),V}}}) = OrderedDict{Any,V}(kv)"
-_newOrderedDict1 = "OrderedDict{V}(kv::Tuple{Vararg{Pair{K,V} where K}})   = OrderedDict{Any,V}(kv)"
+_oldOrderedDict1 = "OrderedDict(kv::Tuple{Vararg{Pair{TypeVar(:K),V}}}) where {V} = OrderedDict{Any,V}(kv)"
+_newOrderedDict1 = "OrderedDict(kv::Tuple{Vararg{Pair{K,V} where K}}) where {V}   = OrderedDict{Any,V}(kv)"
 OrderedDict(kv::Tuple{Vararg{Pair{K,V}}}) where {K,V}         = OrderedDict{K,V}(kv)
 OrderedDict(kv::Tuple{Vararg{Pair{K}}}) where {K}             = OrderedDict{K,Any}(kv)
 VERSION < v"0.6.0-dev.2123" ? _include_string(_oldOrderedDict1) : _include_string(_newOrderedDict1)


Julia <0.6 release is not supported, so this stuff can go, and just the real code can be put in.

oxinabox · 2017-12-06T09:55:27Z

src/ordered_dict.jl

-_oldOrderedDict2 = "OrderedDict{V}(ps::Pair{TypeVar(:K),V}...,) = OrderedDict{Any,V}(ps)"
-_newOrderedDict2 = "OrderedDict{V}(ps::(Pair{K,V} where K)...,) = OrderedDict{Any,V}(ps)"
+_oldOrderedDict2 = "OrderedDict(ps::Pair{TypeVar(:K),V}...,) where {V} = OrderedDict{Any,V}(ps)"
+_newOrderedDict2 = "OrderedDict(ps::(Pair{K,V} where K)...,) where {V} = OrderedDict{Any,V}(ps)"
 OrderedDict(ps::Pair{K,V}...) where {K,V}          = OrderedDict{K,V}(ps)
 OrderedDict(ps::Pair{K}...,) where {K}             = OrderedDict{K,Any}(ps)
 VERSION < v"0.6.0-dev.2123" ? _include_string(_oldOrderedDict2) : _include_string(_newOrderedDict2)


oxinabox · 2017-12-06T09:59:03Z

test/test_ordered_set.jl

-    @test findfirst(s,2) == 0
+    @test findfirst(equalto(1), s) == 1
+    @test findfirst(equalto(7), s) == 4
+    @test findfirst(equalto(2), s) == 0


I guess these are coming in from Compat ?
It is a nice feature

Yes, JuliaLang/julia#23812 on master and JuliaLang/Compat.jl#405 in Compat.

- use uninitialized for Array and BitArray constructors - parse -> Meta.parse - findfirst(x, v) -> findfirst(equalto(v), x) - some syntax deprecation warnings for parametric methods

fredrikekre · 2017-12-06T10:09:43Z

Removed the old code, which lets us remove the _include_string definition as well.

fredrikekre closed this Dec 1, 2017

fredrikekre reopened this Dec 1, 2017

fredrikekre force-pushed the fe/uninitialized branch 3 times, most recently from 56a125b to 64026e8 Compare December 2, 2017 16:18

fredrikekre mentioned this pull request Dec 2, 2017

add KeySet JuliaLang/Compat.jl#423

Closed

fredrikekre force-pushed the fe/uninitialized branch 2 times, most recently from 576807a to fd742b0 Compare December 3, 2017 09:18

ViralBShah mentioned this pull request Dec 3, 2017

Migrate doc from Sphinx to Documenter #347

Merged

martinholters reviewed Dec 6, 2017

View reviewed changes

fredrikekre force-pushed the fe/uninitialized branch 2 times, most recently from 07d19a6 to aa3460b Compare December 6, 2017 09:48

oxinabox mentioned this pull request Dec 6, 2017

Split up the package? #310

Open

fredrikekre force-pushed the fe/uninitialized branch from aa3460b to 57ff7f5 Compare December 6, 2017 09:58

oxinabox approved these changes Dec 6, 2017

View reviewed changes

fix deprecations for 0.7

ef72847

- use uninitialized for Array and BitArray constructors - parse -> Meta.parse - findfirst(x, v) -> findfirst(equalto(v), x) - some syntax deprecation warnings for parametric methods

fredrikekre force-pushed the fe/uninitialized branch from 57ff7f5 to ef72847 Compare December 6, 2017 10:08

ararslan merged commit 2f64978 into JuliaCollections:master Dec 6, 2017

fredrikekre deleted the fe/uninitialized branch December 6, 2017 19:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix deprecated array constructors #348

fix deprecated array constructors #348

fredrikekre commented Dec 1, 2017

fredrikekre commented Dec 1, 2017

fredrikekre commented Dec 1, 2017

fredrikekre commented Dec 2, 2017

codecov bot commented Dec 2, 2017 •

edited

Loading

oxinabox commented Dec 6, 2017

martinholters commented Dec 6, 2017

martinholters Dec 6, 2017

fredrikekre Dec 6, 2017

fredrikekre commented Dec 6, 2017

oxinabox left a comment •

edited

Loading

oxinabox Dec 6, 2017

oxinabox Dec 6, 2017

oxinabox Dec 6, 2017

fredrikekre Dec 6, 2017

fredrikekre commented Dec 6, 2017

fix deprecated array constructors #348

fix deprecated array constructors #348

Conversation

fredrikekre commented Dec 1, 2017

fredrikekre commented Dec 1, 2017

fredrikekre commented Dec 1, 2017

fredrikekre commented Dec 2, 2017

codecov bot commented Dec 2, 2017 • edited Loading

Codecov Report

oxinabox commented Dec 6, 2017

martinholters commented Dec 6, 2017

martinholters Dec 6, 2017

Choose a reason for hiding this comment

fredrikekre Dec 6, 2017

Choose a reason for hiding this comment

fredrikekre commented Dec 6, 2017

oxinabox left a comment • edited Loading

Choose a reason for hiding this comment

oxinabox Dec 6, 2017

Choose a reason for hiding this comment

oxinabox Dec 6, 2017

Choose a reason for hiding this comment

oxinabox Dec 6, 2017

Choose a reason for hiding this comment

fredrikekre Dec 6, 2017

Choose a reason for hiding this comment

fredrikekre commented Dec 6, 2017

codecov bot commented Dec 2, 2017 •

edited

Loading

oxinabox left a comment •

edited

Loading