Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add KeySet #423

Closed
wants to merge 1 commit into from
Closed

add KeySet #423

wants to merge 1 commit into from

Conversation

fredrikekre
Copy link
Member

No description provided.

@fredrikekre
Copy link
Member Author

ref JuliaCollections/DataStructures.jl#348

@fredrikekre
Copy link
Member Author

This is a bit iffy. Probably better for packages that need this to solve it locally. I guess this type is not used that much anyway.

andyferris
andyferris approved these changes Dec 2, 2017
View reviewed changes
Copy link
Member

@andyferris andyferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fascinating typealias.

I guess this would provide most of the required compatibility (still won't dispatch to AbstractSet)?

@andyferris
Copy link
Member

Probably better for packages that need this to solve it locally. I guess this type is not used that much anyway.

I find this hard to judge (I've had little experience with Compat anyway).

@fredrikekre
Copy link
Member Author

In all registered packages, apart from in DataStructures, this: https://github.com/BenLauwens/ResumableFunctions.jl/blob/ec55bcf9bc1cd24ba84b28743e10953795f1d90d/src/transforms.jl#L22 is the only place where KeyIterator is used. Since this PR does not offer the complete functionality of KeySet I think it is better to do local fixes for this, and not provide it from Compat.

@fredrikekre fredrikekre closed this Dec 3, 2017
@fredrikekre fredrikekre deleted the fe/keyset branch March 9, 2018 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyferris andyferris andyferris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekre @andyferris