-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Disabling scopes doesn't work if there's only one scope #908
Comments
Duplicate of #854 (comment) But I do agree that this is a bit unintuitive and disabling all scopes should result in disabling all scopes. |
@JohannesKlauss if this is a duplicate shouldn't this one be closed and #854 be opened? |
Are you still considering having active scopes as an empty array instead of ["*"] when all scopes are disabled, so I can create a pull request to this? @JohannesKlauss |
Yes, you are absolutey welcome to create a PR for this. Since it is a breaking change this will be released in version 5 |
Describe the bug
When only one scope is enabled, disabling that scope has the effect of enabling all scopes.
To Reproduce
<HotkeysProvider />
).Please try and add a codesandbox or stackblitz to reproduce the bug:
https://codesandbox.io/s/laughing-zhukovsky-vnrqlj?file=/src/App.js
Expected behavior
Disabling the scope of a hotkey should disable the hotkey. And the behavior where disabling all scopes is the same as enabling all scopes is confusing (at least to me).
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: