Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling all scopes turns everything on #854

Closed
ptya opened this issue Nov 25, 2022 · 3 comments
Closed

Disabling all scopes turns everything on #854

ptya opened this issue Nov 25, 2022 · 3 comments

Comments

@ptya
Copy link

ptya commented Nov 25, 2022

Hi,
Just as I wrote my other issue I noticed a potential bug in the code. Now when you disable a scope, and there are no more enabled scopes after filtering, instead of turning everything off, the codes turns everything back on again. I don't think that is the intended usecase here.

@JohannesKlauss
Copy link
Owner

JohannesKlauss commented Nov 30, 2022

Thank you for reporting the issue. I'll release a fix for that

@JohannesKlauss
Copy link
Owner

JohannesKlauss commented Dec 10, 2022

This is actually intended behavior. If you disable all specific scopes the wildcard scope will be active which means all scopes are active. Although thinking about it this seems very counter intuitive and I might change that in a 4.1 version.

The initial reasoning behind this was, that all hotkeys work out of the box and if you need a specific focus on a component subtree you can activate a scope for the lifetime of that subtree.

Right now you can workaround by initially setting a scope none, which has no hotkeys assigned and never gets deactivated. This way only the active scopes are triggering.

@colinricardo
Copy link

@JohannesKlauss is there a recommended way of disabling all scopes? looping over the active scopes and calling disableScope doesn't seem to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants