Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update electron to 2.0.16, electron-builder 20.34.0 #373

Merged
merged 3 commits into from
Jan 7, 2019
Merged

update electron to 2.0.16, electron-builder 20.34.0 #373

merged 3 commits into from
Jan 7, 2019

Conversation

trevj
Copy link
Contributor

@trevj trevj commented Jan 7, 2019 •
edited
Loading

@trevj trevj requested a review from fortuna January 7, 2019 20:29
@trevj trevj changed the title update to electron 2.0.16 update electron to 2.0.16, electron-builder 20.34.0 Jan 7, 2019
fortuna
fortuna approved these changes Jan 7, 2019
View reviewed changes
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to switch to Electron 3?

@trevj
Copy link
Contributor Author

trevj commented Jan 7, 2019

Could be :-)

@trevj trevj merged commit 3f63fe3 into master Jan 7, 2019
@trevj trevj deleted the trevj-update-electron branch January 7, 2019 21:22
@trevj trevj mentioned this pull request Jan 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fortuna fortuna fortuna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trevj @fortuna