Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this.app.whenReady is not a function when running electron-updater #3505

Closed
jetlej opened this issue Nov 27, 2018 · 2 comments
Closed

this.app.whenReady is not a function when running electron-updater #3505

jetlej opened this issue Nov 27, 2018 · 2 comments

Comments

@jetlej
Copy link

jetlej commented Nov 27, 2018

  • Version: 20.36.2
  • electron-updater: 4.0.4
  • Target: mac + web

I'm trying to use electron-updater, but I get this error:

TypeError: this.app.whenReady is not a function
at ElectronAppAdapter.whenReady (/Users/jetlej/Projects/Task Slayer/code/node_modules/electron-updater/src/ElectronAppAdapter.ts:9:21)

Comes from this code:

app.on('ready', () => {
  autoUpdater.checkForUpdates()
})
@zhaoterryy
Copy link
Collaborator

zhaoterryy commented Nov 27, 2018

What Electron version are you running?

electron-builder > 20.35.0 requires Electron 3.

@jetlej
Copy link
Author

jetlej commented Nov 27, 2018

That was the issue. Upgrading to electron 3.0 made it work! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants