feat(metrics_server): do not invalidate legacy report types #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbruens
changed the title
fortuna
requested changes
Apr 5, 2024
sbruens
commented
Apr 5, 2024
Actually, nevermind this - I didn't initially see your top-level comment re: dropping them. |
fortuna
approved these changes
Apr 18, 2024
| for (const userReport of testObject.userReports) { | ||
| // Check that `bytesTransferred` is a number between min and max transfer limits | ||
| // We require at least the userId or the country to be set. | ||
| if (!userReport.userId && (userReport.countries?.length ?? 0) === 0) { |
There was a problem hiding this comment.
I think this check is unnecessary, since the body here already knows how to trigger on the different cases. It's no big issue, but it's kind of duplicated logic. And if we add new report types in the future, this will have to change.
There was a problem hiding this comment.
It knows how to handle those properties, but it doesn't verify that the report has at least 1 of them. I'll remove it and change the model to make it more forgiving, though I don't think we ever allowed neither to be set?
fortuna
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Servers released before #1242 or #1529 will continue to send reports with multiple
countriesor auserIdproperty respectively. This change reinstates backwards compatibility (broken in #1528) and makes support for these old types more explicit to help future devs.