Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): restore country metrics #1242

Merged
merged 11 commits into from
Dec 2, 2022
Merged

fix(server): restore country metrics #1242

merged 11 commits into from
Dec 2, 2022

Conversation

fortuna
Copy link
Collaborator

@fortuna fortuna commented Dec 1, 2022

Data usage is no longer linked to both key and country.
We now query usage twice: one for key and one for country, and report both.

@github-actions github-actions bot added the size/M label Dec 1, 2022
@fortuna fortuna changed the title Fix metrics fix: restore country metrics Dec 1, 2022
@fortuna fortuna changed the title fix: restore country metrics fix(server): restore country metrics Dec 1, 2022
@fortuna fortuna requested a review from a team as a code owner December 2, 2022 00:58
@github-actions github-actions bot added size/L and removed size/M labels Dec 2, 2022
@fortuna
Copy link
Collaborator Author

fortuna commented Dec 2, 2022

I deployed the change to dev and confirmed it's working:
image

src/metrics_server/connection_metrics.ts Outdated Show resolved Hide resolved
fortuna and others added 2 commits December 2, 2022 09:07
Co-authored-by: J. Yi <93548144+jyyi1@users.noreply.github.com>
@fortuna fortuna merged commit c324848 into master Dec 2, 2022
@fortuna fortuna deleted the fortuna-metrics branch December 2, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants