Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): api specification #1503

Merged
merged 2 commits into from
Feb 12, 2024
Merged

fix(server): api specification #1503

merged 2 commits into from
Feb 12, 2024

Conversation

murka
Copy link
Contributor

@murka murka commented Feb 6, 2024

fix: #1499

@murka murka requested a review from fortuna as a code owner February 6, 2024 08:53
@murka
Copy link
Contributor Author

murka commented Feb 6, 2024

hm, git diff is not correctly, I move PUT method from access-keys into access-keys/{id}, as per

outline-server/src/shadowbox/server/manager_service.ts

Line 142 in 64c4f94

apiServer.put(`${apiPrefix}/access-keys/:id`, service.createAccessKey.bind(service));

sbruens
sbruens approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@sbruens sbruens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@sbruens
Copy link
Contributor

sbruens commented Feb 9, 2024

Sorry, do you mind resolving the conflicts? Then I'll merge it.

@murka
Copy link
Contributor Author

murka commented Feb 11, 2024

I did it.

@sbruens sbruens merged commit 9779f5d into Jigsaw-Code:master Feb 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbruens sbruens sbruens approved these changes

@fortuna fortuna Awaiting requested review from fortuna fortuna is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Puth method in /access-keys needs to use {id} in the path
2 participants
@murka @sbruens