Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puth method in /access-keys needs to use {id} in the path #1499

Closed
jadolg opened this issue Feb 5, 2024 · 1 comment · Fixed by #1503
Closed

Puth method in /access-keys needs to use {id} in the path #1499

jadolg opened this issue Feb 5, 2024 · 1 comment · Fixed by #1503
Assignees
@sbruens

Comments

@jadolg
Copy link

jadolg commented Feb 5, 2024

The method to create a key with a specific id operates under /access-keys/{id} and not under just /access-keys

outline-server/src/shadowbox/server/api.yml

Line 178 in 64c4f94

put:

The code is correct but the API docs are not
murka added a commit to murka/outline-server that referenced this issue Feb 6, 2024
@murka
fix(server): api specification Jigsaw-Code#1499
405def1
@murka murka mentioned this issue Feb 6, 2024
Merged
@sbruens sbruens self-assigned this Feb 9, 2024
sbruens pushed a commit that referenced this issue Feb 12, 2024
@murka
fix(server): api specification #1499 (#1503)
9779f5d
@sbruens
Copy link
Contributor

sbruens commented Feb 12, 2024

Thank you @murka for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbruens sbruens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(server): api specification murka/outline-server
2 participants
@sbruens @jadolg