Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(manager): detect platform before shifting the arg array in package action #1500

Merged
merged 4 commits into from
Feb 6, 2024
Merged

build(manager): detect platform before shifting the arg array in package action #1500

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3cb71dd
fix(manager): detect platform before shifting the arg array in the pa…
daniellacosse Feb 6, 2024
a685a99
Update package.action.sh
daniellacosse Feb 6, 2024
4ba742f
Update src/server_manager/electron_app/package.action.sh
daniellacosse Feb 6, 2024
11bc5f1
Update src/server_manager/electron_app/package.action.sh
daniellacosse Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/server_manager/electron_app/package.action.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ function finish_yaml_files() {
function main() {
declare staging_percentage=100
declare version_name='0.0.0-debug'

for i in "$@"; do
case "${i}" in
--buildMode=*)
Expand All @@ -91,10 +92,11 @@ function main() {
echo "Unknown option: ${i}"
exit 1
;;
*) ;;
*) # only supports having one platform
daniellacosse marked this conversation as resolved.
Show resolved Hide resolved
PLATFORM="${i?Platform missing}"
daniellacosse marked this conversation as resolved.
Show resolved Hide resolved
;;
esac
done
PLATFORM="${1?Platform missing}"
run_action server_manager/electron_app/build --buildMode="${BUILD_MODE}" --versionName="${version_name}"
package_electron
finish_yaml_files "${staging_percentage}"
Expand Down
Loading