Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(manager): detect platform before shifting the arg array in package action #1500

Merged
merged 4 commits into from
Feb 6, 2024
Merged

build(manager): detect platform before shifting the arg array in package action #1500

merged 4 commits into from
Feb 6, 2024

Conversation

daniellacosse
Copy link
Contributor

shift mutates the $@ array, so by the time the script was getting here, $PLATFORM was the wrong thing:

Screenshot 2024-02-05 at 8 28 51 PM

@daniellacosse daniellacosse requested a review from a team as a code owner February 6, 2024 01:29
@daniellacosse
Copy link
Contributor Author

Why were we shifting anyway? Do we have to do that?

jyyi1
jyyi1 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the I would suggest the title to be build(manager): ...

@daniellacosse daniellacosse changed the title fix(manager): detect platform before shifting the arg array in package action build(manager): detect platform before shifting the arg array in package action Feb 6, 2024
@fortuna
Copy link
Collaborator

fortuna commented Feb 6, 2024

What if the flag comes before the platform?

@daniellacosse
Copy link
Contributor Author

What if the flag comes before the platform?

Updated!

fortuna
fortuna approved these changes Feb 6, 2024
View reviewed changes
src/server_manager/electron_app/package.action.sh Outdated Show resolved Hide resolved
src/server_manager/electron_app/package.action.sh Outdated Show resolved Hide resolved
daniellacosse and others added 2 commits February 6, 2024 12:53
@daniellacosse @fortuna
Update src/server_manager/electron_app/package.action.sh
4ba742f 
Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>
@daniellacosse @fortuna
Update src/server_manager/electron_app/package.action.sh
11bc5f1 
Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>
@daniellacosse daniellacosse merged commit 0fba65e into master Feb 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyyi1 jyyi1 jyyi1 approved these changes

@sbruens sbruens sbruens approved these changes

@fortuna fortuna fortuna approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daniellacosse @fortuna @sbruens @jyyi1