Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manager): adjust app container on narrow devices to make room for sidebar #1495

Merged
merged 2 commits into from
Feb 2, 2024
Merged

fix(manager): adjust app container on narrow devices to make room for sidebar #1495

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f465910
i feel disguisting lol
daniellacosse Feb 2, 2024
60ef280
app container is better
daniellacosse Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/server_manager/web_app/ui_components/app-root.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,11 @@ export class AppRoot extends polymerElementWithLocalize {
#getConnectedDialog .buttons {
margin-top: -5px; /* undo spacing added after iframe */
}
@media (max-width: 887px) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems Material uses 840dp as the breakpoint: https://m3.material.io/foundations/layout/applying-layout/window-size-classes

Maybe we should follow that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dp is android only btw: https://stackoverflow.com/questions/16390762/whats-dp-density-independent-pixels-units-with-css

.app-container {
margin-left: 50px;
}
}
</style>

<outline-tos-view id="tosView" has-accepted-terms-of-service="{{userAcceptedTos}}" hidden\$="{{hasAcceptedTos}}" localize="[[localize]]"></outline-tos-view>
Expand Down
Loading