fix(manager): adjust app container on narrow devices to make room for sidebar #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellacosse
changed the title
|
I don't understand what the issue is. We use the off-the-shelf https://www.webcomponents.org/element/@polymer/app-layout/elements/app-drawer-layout. It has always worked. What changed? Edit: Oh, I see your comment on dependencies. Not clear to me how that would affect it, Polymer is not updated. |
fortuna
reviewed
Feb 2, 2024
| @@ -372,6 +372,11 @@ export class AppRoot extends polymerElementWithLocalize { | |||
| #getConnectedDialog .buttons { | |||
| margin-top: -5px; /* undo spacing added after iframe */ | |||
| } | |||
| @media (max-width: 887px) { | |||
There was a problem hiding this comment.
It seems Material uses 840dp as the breakpoint: https://m3.material.io/foundations/layout/applying-layout/window-size-classes
Maybe we should follow that?
There was a problem hiding this comment.
dp is android only btw: https://stackoverflow.com/questions/16390762/whats-dp-density-independent-pixels-units-with-css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is horrible, I feel like god told me to kill my own brother
the sidebar and the main page for whatever reason are on different layers. I would have to restructure the UI and (possibly) rip out some of the components we're using to do it properly (they should be in a flex layout on the same layer). for now, to unblock the release I am simply using a grotesque media query to make room for the sidebar when the app is narrow.
my guess is this behavior started when our dependencies were updated at some point