Fix a native crash on makeGL
#869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
force-pushed
the
igor.demin/fix-opengl-context-regression
branch
from
8a29d8e
to
7a4b50a
Compare
It is a regression after #811 After that PR, OpenGL functions are linked in runtime via function `loadOpenGLLibrary`. We didn't call it in `makeGL` functions. Now we call. Adding also `isLoaded` to avoid loading it multiple times Fixes https://youtrack.jetbrains.com/issue/COMPOSE-642/Fix-Skiko-API-regression-for-creating-OpenGL-context
igordmn
force-pushed
the
igor.demin/fix-opengl-context-regression
branch
from
7a4b50a
to
29d7328
Compare
| fbFormat | ||
| ) | ||
| ) | ||
| loadOpenGLLibrary() |
There was a problem hiding this comment.
Do we ever create BackendRenderTarget before initialising context? From a first look this one seems redundant.
There was a problem hiding this comment.
Seems it isn't needed indeed. But not because we init context. Because we can create it without context and even without OpenGL. Checked it just now.
elijah-semyonov
approved these changes
Feb 9, 2024
|
This change affected CfW (k/js) running in Safari :) https://kotlinlang.slack.com/archives/C01F2HV7868/p1708540690334899?thread_ts=1708527218.429189&cid=C01F2HV7868 |
igordmn
added a commit
that referenced
this pull request
Apr 16, 2024
By request from user in DM who uses LWJGL+Skiko on macOS. Let Skia throw an error if it isn't supported, not Skiko. Skiko works well without it, as it doesn't use any OpenGL inside Skiko classes (particularly SkiaLayer). The original error was added in #869, the main purpose of which was to fix a Windows issue, macOs was added just by an assumption that it is no longer can work ## Testing Existing tests works (SkiaLayerTest, DirectContextTest)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a regression after #811
After that PR, OpenGL functions are linked in runtime via function
loadOpenGLLibrary. We didn't call it inmakeGLfunctions. Now we call.makeGLisLoadedto avoid loading it multiple timesFixes JetBrains/compose-multiplatform#3972