Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to not throw RenderException when use OpenGL on macOS #915

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

igordmn
Copy link
Collaborator

@igordmn igordmn commented Apr 16, 2024

To allow using OpenGL on macOs, call:

System.setProperty("skiko.macos.opengl.enabled", "true")

By request from user in DM who uses LWJGL+Skiko on macOS.

@igordmn igordmn force-pushed the igor.demin/allow-opengl-on-macos branch from 36c1124 to c44f79f Compare April 18, 2024 00:30
To allow using OpenGL on macOs, call:
```
System.setProperty("skiko.macos.opengl.enabled", "true")
```

By request from user in DM who uses LWJGL+Skiko on macOS.
@igordmn igordmn force-pushed the igor.demin/allow-opengl-on-macos branch from c44f79f to 548077e Compare April 18, 2024 00:32
@igordmn
Copy link
Collaborator Author

igordmn commented Apr 18, 2024

The PR is changed.

Now we just add a flag to reenable OpenGL.

Enabling OpenGL by default isn't trivial, because we need to throw RenderException if OpenGL isn't available (for cases when user knows how to handle it, for example - switch to Software rendering). macOs natively crashes comparing to Windows/Linux.

For iOS there weren't requests from users, and it seems it didn't work, as we didn't link the OpenGL framework before.

@igordmn igordmn changed the title Remove iOS/macOS error on OpenGL initialization Remove macOS error on OpenGL initialization Apr 18, 2024
@igordmn igordmn changed the title Remove macOS error on OpenGL initialization Option to not throw RenderException when use OpenGL on macOS Apr 18, 2024
@igordmn igordmn merged commit 37ef84b into master Apr 18, 2024
5 checks passed
@igordmn igordmn deleted the igor.demin/allow-opengl-on-macos branch April 18, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants