Skip to content
This repository has been archived by the owner on Aug 10, 2021. It is now read-only.

Update: Gradle 4.10 #2187

Merged
merged 2 commits into from
Oct 10, 2018
Merged

Update: Gradle 4.10 #2187

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a106f8
Update: Gradle 4.10
ilmat192 Oct 9, 2018
c2aebee
Add comment about using shared in Gradle plugin build
ilmat192 Oct 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add comment about using shared in Gradle plugin build
  • Loading branch information
@ilmat192
ilmat192 committed Oct 10, 2018
commit c2aebee8e8fd3d94c0f798be93d86adfb6b9ea38
4 changes: 4 additions & 0 deletions tools/kotlin-native-gradle-plugin/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ apply plugin: 'com.github.johnrengelman.shadow'

group = 'org.jetbrains.kotlin'

// With Gradle 4.10 we are no longer able to depend on
// a 'shared' build included into the root one and use the KonanVersion API provided
// by it. So we have to manually construct the version.
// TODO: Remove this code when 'shared' is built separately (from a separate repo).
def meta = findProperty('konanMetaVersion') ?: 'dev'
Copy link
Contributor

@vvlevchenko vvlevchenko Oct 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it'd better to add TODO why we can't read KonanVersion and use other sources of version information and how will deal with it in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

if (meta == 'release') {
version = kotlinVersion
Expand Down