This repository has been archived by the owner on Aug 10, 2021. It is now read-only.
Update: Gradle 4.10 #2187
Merged
Update: Gradle 4.10 #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvlevchenko
reviewed
Oct 10, 2018
| @@ -55,10 +51,15 @@ apply plugin: 'com.github.johnrengelman.shadow' | |||
|
|
|||
| group = 'org.jetbrains.kotlin' | |||
|
|
|||
| if (KonanVersion.Companion.CURRENT.meta == MetaVersion.RELEASE) { | |||
| def meta = findProperty('konanMetaVersion') ?: 'dev' | |||
There was a problem hiding this comment.
Here it'd better to add TODO why we can't read KonanVersion and use other sources of version information and how will deal with it in the future.
vvlevchenko
reviewed
Oct 10, 2018
| includeBuild '../../shared' |
vvlevchenko
approved these changes
Oct 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.