[Dart] Update the Dart parser and tests to cover Dart Super-Initializer Parameters #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwilkerson
approved these changes
Jan 24, 2022
| @@ -382,7 +382,7 @@ formalParameterList ::= '(' ')' | | |||
| '(' optionalFormalParameters ')' | |||
| private normalFormalParameters ::= normalFormalParameter (',' normalFormalParameter)* | |||
|
|
|||
| fieldFormalParameter ::= metadata* finalConstVarVoidOrType? 'this' '.' referenceExpression typeParameters? formalParameterList? | |||
| fieldFormalParameter ::= metadata* finalConstVarVoidOrType? ('this' | 'super') '.' referenceExpression typeParameters? formalParameterList? | |||
There was a problem hiding this comment.
You might want to rename the production to fieldOrSuperFormalParameter, but it doesn't change the semantics, so up to you.
| class ConstructorSyntax2 extends SuperClass { | ||
| ConstructorSyntax2(this.x, super.y, [super.z]) : super(a, b); | ||
| ConstructorSyntax2.c(this.x, super.y, [super.z]) : super(a, b); | ||
| ConstructorSyntax2.d(this.x, super.y, {super.z}) : super(a, b); |
There was a problem hiding this comment.
You might want at least one example with more complete syntax.
SergeyZh
pushed a commit
that referenced
this pull request
Mar 4, 2022
…meters close #853 (cherry picked from commit 8053388ab977a0c37b5b4c3c41dedbbefc9dbacd) (cherry picked from commit af6c9cec36dbb87c772696ca7aed78fddef30e5a) GitOrigin-RevId: e50ed5c6e1fa763ce225377eb04a96b610c92293
SergeyZh
pushed a commit
that referenced
this pull request
Mar 4, 2022
…meters close #853 (cherry picked from commit 8053388ab977a0c37b5b4c3c41dedbbefc9dbacd) (cherry picked from commit af6c9cec36dbb87c772696ca7aed78fddef30e5a) (cherry picked from commit e50ed5c6e1fa763ce225377eb04a96b610c92293) GitOrigin-RevId: 80e012a6e14f160cb624b87eaea66f7529e79c03
SergeyZh
pushed a commit
that referenced
this pull request
Mar 4, 2022
…meters close #853 (cherry picked from commit 8053388ab977a0c37b5b4c3c41dedbbefc9dbacd) GitOrigin-RevId: af6c9cec36dbb87c772696ca7aed78fddef30e5a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart-lang/sdk#48074
https://github.com/dart-lang/language/blob/master/working/1855%20-%20super%20parameters/proposal.md
@alexander-doroshko
@scheglov
@bwilkerson