Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IntelliJ implementation for super-initializer parameters #48074

Closed
Tracked by #48055
devoncarew opened this issue Jan 4, 2022 · 3 comments
Closed
Tracked by #48055

IntelliJ implementation for super-initializer parameters #48074

devoncarew opened this issue Jan 4, 2022 · 3 comments
Assignees
@jwren
Labels
area-intellij Tracking issues for the Dart IntelliJ plugin.

Comments

@devoncarew
Copy link
Member

devoncarew commented Jan 4, 2022 •
edited
Loading

See #48055 for the main tracking issue.
@devoncarew devoncarew mentioned this issue Jan 4, 2022
Closed
23 tasks
@devoncarew devoncarew changed the title IntelliJ implementation for super-initializer parameters (todo:) IntelliJ implementation for super-initializer parameters Jan 4, 2022
@devoncarew devoncarew added the area-intellij Tracking issues for the Dart IntelliJ plugin. label Jan 4, 2022
@devoncarew
Copy link
Member Author

cc @jwren

@stereotype441
Copy link
Member

Note: in our planning meeting on Dec 13, it was suggested that when the user hovers over an optional super parameter that inherits a default value from the corresponding parameter on the base class, the IDE should show the default value that's being inherited from the base class constructor. Doing so requires work in the analysis server, and possibly in some of the IDE integration logic.

jwren added a commit to jwren/intellij-plugins that referenced this issue Jan 24, 2022
@jwren
[Dart] Update the Dart parser and tests to cover Dart Super-Initializ…
e2a225d 
…er Parameters

dart-lang/sdk#48074
https://github.com/dart-lang/language/blob/master/working/1855%20-%20super%20parameters/proposal.md
@jwren jwren mentioned this issue Jan 24, 2022
Closed
copybara-service bot pushed a commit that referenced this issue Jan 25, 2022
@scheglov
Issue 48074. Display inherited default value for super-parameters.
06e9046 
Bug: #48074
Change-Id: I964141c9b2a1ccf4a2d08d6bfff7675aa6df9d5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
@alexander-doroshko
Copy link

This seems to have been fixed in the Dart plugin quite some time ago. Feel free to close the issue.

@jwren jwren closed this as completed Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwren jwren

Labels
area-intellij Tracking issues for the Dart IntelliJ plugin.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stereotype441 @devoncarew @jwren @alexander-doroshko