-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate variable webfonts #535
Conversation
Hey JetBrains, Cheers |
@philippnurullin Anything I can do to get this merged? I'd be happy to work on this further if you've any suggestions. |
@naiyerasif Hi, and sorry for the long wait. @RosaWagner Hi. Can you please look at the build script modifications and validate them? |
It's all fine. |
@naiyerasif |
@philippnurullin Seems like an issue with the latest job. I can see that the build didn't run fully. I took the latest changes in my fork and ran the job here to verify if my script is running: https://github.com/naiyerasif/JetBrainsMono/actions/runs/4064950771 |
Hi @naiyerasif So, I need your help to fix the script and find the solution. |
@philippnurullin Can you please provide me a reproduction of the issue so that I can investigate this? e.g. how are you trying to generate the font? Are you running it on local or on GitHub Actions? For my demonstration, I pulled the HEAD of this very repository, ran the exact same GitHub Actions workflow that is used officially and the results are available for you to verify: https://github.com/naiyerasif/JetBrainsMono/actions/runs/4064950771 If you're trying to run this on local, you'll have to run # this command generates the files in `fonts/variable` directory
gftools builder sources/config.yaml
# this script picks the `ttf` files from `fonts/variable` directory and converts them to `woff2` files
python scripts/generate_variable_webfonts.py |
Mac OS Ventura 13x
The script is running but produce no results. |
Also, run code in IntelliJ IDEA. Result:
Still no new files in |
This is a path resolution issue. Can you try the following instructions and see if things work?
I've also created a PR #602 with updated instructions. Tested this on Alpine Linux but this should work on other ecosystems as well. |
Thanks. It works! |
This change adds
fontTools.ttLib
based build script that can generate variable webfonts fromttf
files. It runs after thegftools
and dumps thewoff2
fonts infonts/variable
directory. The script does not modify any files generated bygftools
.A test run for this change (not including upload) is available here: https://github.com/naiyerasif/JetBrainsMono/runs/5702196890?check_suite_focus=true