Fix handshake with Node.js not completing when external systems interfere with Node.js's stdout stream #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed regex pattern. - Updated tests. - Minor re-arranging of class members.
Member
|
It looks great! I've cleaned up the tests and added you to the ReadMe contributor list. I need to update the Azure pipeline. Will publish a new package once that's done, probably in a couple of hours. |
JeremyTCD
changed the title
Member
|
New package is live: 7.0.0-beta.0. Bumped to 7.0.0 because the public API changed. Thanks for the contribution, really appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did not have time to test it yet, but let me know if I'm on the right track