Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump macaddress from 0.2.8 to 0.2.9 #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

This is a React/Redux single page app that can be used as boilerplate for any starting project, or simply for educational purposes.

**NOTE: This boilerplate is years old (which in the frontend world is like decades old), and at this point is outdated. Webpack, Babel, React-Router, etc. all need to be upgraded (unfortunately not as trivial as changing versions). Thus I do not recommend using this boilerplate beyond simply being a reference.

### Features:

* Universal/Isomorphic rendering
Expand Down
9 changes: 7 additions & 2 deletions webpack/development/dev.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ var webpack = require('webpack')
const ROOT = '../..'
const PORT = require(ROOT + '/config/serverConfig.json').PORT

require('../symlinks')()

var configVars = {
NODE_ENV: JSON.stringify('development'),
BROWSER: JSON.stringify(true)
Expand All @@ -24,6 +22,13 @@ module.exports = {
filename: 'js/main.bundle.js',
publicPath: `http://localhost:${PORT}/`
},
resolve: {
alias: {
Src: path.join(__dirname, ROOT + '/src'),
Config: path.join(__dirname, ROOT + '/config'),
},
extensions: ['.js', '.jsx']
},
plugins: [
new webpack.LoaderOptionsPlugin({
debug: true,
Expand Down
13 changes: 9 additions & 4 deletions webpack/production/prod.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,15 @@ var WebpackMd5Hash = require('webpack-md5-hash') //required for ChunkManifestPlu
var ManifestPlugin = require('webpack-manifest-plugin')
const ROOT = '../..'

require('../symlinks')()

const VERSION = require(ROOT + '/package.json').version || '0.0.0'
// const VERSION = require(ROOT + '/package.json').version || '0.0.0'

var configVars = {
NODE_ENV: JSON.stringify('production'),
BROWSER: JSON.stringify(true)
}

const config = require(ROOT + '/config/config.js')['production']
const { STATIC_URL } = config
// const { STATIC_URL } = config

module.exports = {
context: path.resolve(__dirname, ROOT),
Expand All @@ -41,6 +39,13 @@ module.exports = {
filename: 'js/[name]_[chunkhash]_bundle.js',
chunkFilename: 'js/[name]_[chunkhash]_chunk.js'
},
resolve: {
alias: {
Src: path.join(__dirname, ROOT + '/src'),
Config: path.join(__dirname, ROOT + '/config'),
},
extensions: ['.js', '.jsx']
},
plugins: [
new webpack.LoaderOptionsPlugin({
minimize: true,
Expand Down
17 changes: 0 additions & 17 deletions webpack/symlinks.js

This file was deleted.

4 changes: 2 additions & 2 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3061,8 +3061,8 @@ lru-cache@^4.0.1:
yallist "^2.0.0"

macaddress@^0.2.8:
version "0.2.8"
resolved "https://registry.yarnpkg.com/macaddress/-/macaddress-0.2.8.tgz#5904dc537c39ec6dbefeae902327135fa8511f12"
version "0.2.9"
resolved "https://registry.yarnpkg.com/macaddress/-/macaddress-0.2.9.tgz#3579b8b9acd5b96b4553abf0f394185a86813cb3"

map-obj@^1.0.0, map-obj@^1.0.1:
version "1.0.1"
Expand Down