feat: changes and fixes #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asimkt
commented
Aug 8, 2021
| html { | ||
| font-size: 12px; | ||
| } | ||
| .has-text-centered-mobile { |
There was a problem hiding this comment.
the base font size changed to 12px, though this doesn't make a 1:1 map with actual design for mobile for typography.
asimkt
commented
Aug 8, 2021
| background: var(--bg-sub); | ||
| /* @hiran, do we need this border radius? - @asim */ | ||
| border-radius: 8px; | ||
| width: 100%; |
There was a problem hiding this comment.
only this component have a border radius I think
There was a problem hiding this comment.
Yes, I will remove this. TOC Desktop also needs some minor cleanup, like margin-left
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: make base font 12px in mobile
fix(back-btn): color to text-main
fix: post page padding issues
fix(mobile): back btn position
feat: add hamburger menu
feat: add support for dark mode in mobile