Use accessor props to get value and label in compareOption
#4444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2ffed9c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2ffed9c:
|
JedWatson
approved these changes
Feb 10, 2021
|
Thanks @Rall3n! |
This was referenced Feb 18, 2021
Merged
This was referenced Mar 6, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the
compareOptioninternal function for theCreatablecomponent defaults to using thevalueandlabelproperties of options to resolve and find options matching a search string. BesidesgetOptionLabelandgetOptionValuepeople would have to also use theisValidNewOptionprop to accommodate for their custom options.This PR forwards the values of the accessor props
getOptionLabelandgetOptionValueto thecompareOptionfunction to allow for the usage of custom options without the need to overwrite the defaultisValidNewOptionfunction.There was PR #2956 which tried to do the same but failed in using the proper functions (defaulted to hardcoded built-ins).