Use accessor props to get value and label in compareOption
#4444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the
compareOption
internal function for theCreatable
component defaults to using thevalue
andlabel
properties of options to resolve and find options matching a search string. BesidesgetOptionLabel
andgetOptionValue
people would have to also use theisValidNewOption
prop to accommodate for their custom options.This PR forwards the values of the accessor props
getOptionLabel
andgetOptionValue
to thecompareOption
function to allow for the usage of custom options without the need to overwrite the defaultisValidNewOption
function.There was PR #2956 which tried to do the same but failed in using the proper functions (defaulted to hardcoded built-ins).