-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix creatable not supporting Int values and value accessors #2955 #2953 #2956
Conversation
Just saw this PR. Unfortunately this doesn't fix #2953, as that will still use the default I'm wondering for this bug if we can just check for the presence of The alternative is the library can expose |
i thought about checking their types but that seemed like a lot of overhead and i wasnt super familiar with the codebase so i didnt want to get too far down a rabbit hole |
I would do
This only solves this bug. To solve both #2955 and #2953 you should save value and label to temp variables:
|
Any ideas when this will be merged? It looks like a standard use case. |
Fixed in v2.3.0 / 2019-01-18 https://github.com/JedWatson/react-select/releases/tag/v2.3.0 |
Hi @th3fallen, As pointed out by @Alphonse-Indpro, it appears this PR is no longer required. However - if you feel this pull request is still relevant for the latest version, let us know and we'll determine if it should be reopened. |
Thank you for the more thoughtful response here. That pull request doesn't fix the main issue, though, which is that the library is looking for |
Thanks for letting me know @akre54. |
Greetings @th3fallen , Sorry for the extremely late reply to your PR submission. There is quite a backlog of user submitted PR's and the community deserves better than waiting months or years for a collaborator to reply to the work they've done. I wanted to let you know that the issues that this PR addresses has been resolved: As such, I will be closing this, though I feel frustrated for you that this took so long to get resolved and wanted to add that I truly appreciate the time you put into coding a solution. Thank you for being a part of the community and contributing to react-select. |
Resolves #2955 and #2953