Skip to content

Conversation

@JasonXuDeveloper
Copy link
Owner

Summary

  • Remove overly aggressive ignore patterns in codecov.yml that filtered out coverage data from test directories and Editor code (was causing "No coverage reports found" issue)
  • Add ui flag to codecov.yml for tracking JEngine.UI package coverage
  • Add JEngine.UI package to README.md and README_zh_cn.md with coverage badges and feature descriptions

Test plan

  • Verify CI pipeline uploads coverage successfully
  • Check Codecov dashboard shows coverage data after merge
  • Verify util and ui coverage badges display correctly in README

🤖 Generated with Claude Code

- Remove overly aggressive ignore patterns in codecov.yml that filtered
  out coverage data from test directories and Editor code
- Add UI flag to codecov.yml for tracking JEngine.UI package coverage
- Add JEngine.UI package to README.md with coverage badge and features
- Add JEngine.UI package to README_zh_cn.md with Chinese translations

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
Copilot AI review requested due to automatic review settings January 29, 2026 03:17
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 29, 2026
@JasonXuDeveloper JasonXuDeveloper enabled auto-merge (squash) January 29, 2026 03:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes Codecov coverage reporting by removing overly restrictive ignore patterns and adds documentation for the JEngine.UI package.

Changes:

  • Removed ignore patterns in codecov.yml that were filtering out test directories and Editor code, which was causing "No coverage reports found" errors
  • Added ui flag configuration to codecov.yml for tracking JEngine.UI package coverage separately
  • Added JEngine.UI package documentation with coverage badges and feature descriptions to both English and Chinese README files

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
codecov.yml Removed test/Editor ignore patterns that were preventing coverage upload; added UI package flag configuration
README.md Added JEngine.UI package entry with coverage badge and feature descriptions
README_zh_cn.md Added JEngine.UI package entry with coverage badge and feature descriptions (Chinese version)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Add pull_request_review trigger so auto-approve runs when Copilot
finishes reviewing, even if it completes after check runs finish.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
@github-actions github-actions bot added the ci label Jan 29, 2026
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: Copilot review found no issues and Unity Tests passed (or were skipped for non-code changes).

@JasonXuDeveloper JasonXuDeveloper merged commit 5cec86b into master Jan 29, 2026
15 checks passed
@JasonXuDeveloper JasonXuDeveloper deleted the fix/codecov-upload-and-docs branch January 29, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant