Skip to content

Conversation

@JasonXuDeveloper
Copy link
Owner

Summary

  • Add CLAUDE.md with JEngine-specific development guidelines for AI assistants
  • Add .github/instructions/jengine.instructions.md for C# code style guidance
  • Add .github/instructions/code-review.instructions.md for PR review guidance

Details

These files help AI assistants (Claude Code, GitHub Copilot) understand JEngine's:

Architecture

  • Package structure and namespaces
  • Key dependencies (HybridCLR, YooAsset, UniTask, Nino)
  • Encryption subsystem design

Coding Conventions

  • UniTask for async (not Task)
  • XML documentation requirements
  • Naming conventions

Critical Patterns

  • Unity Editor domain reload handling
  • Resource cleanup (ScriptableObjects, events)
  • Thread safety for callback-accessed state
  • SessionState/EditorPrefs for persistent editor data

Test plan

  • Verify CLAUDE.md renders correctly on GitHub
  • Verify Copilot instructions are in correct format

🤖 Generated with Claude Code

- Add CLAUDE.md with JEngine-specific development guidelines
- Add .github/instructions/jengine.instructions.md for C# code style
- Add .github/instructions/code-review.instructions.md for PR reviews

These instructions help AI assistants (Claude, Copilot) understand JEngine's
architecture, coding conventions, and common patterns like:
- UniTask usage for async operations
- Domain reload handling in Editor code
- Resource cleanup for ScriptableObjects
- Thread safety patterns

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive AI assistant documentation to help Claude Code and GitHub Copilot understand JEngine's architecture, coding conventions, and development patterns. The documentation provides guidelines for code generation and review specific to this Unity hot update framework.

Changes:

  • Added CLAUDE.md with detailed JEngine development guidelines including architecture, coding conventions, and common patterns
  • Added .github/instructions/jengine.instructions.md for GitHub Copilot with C# code style guidance specific to JEngine
  • Added .github/instructions/code-review.instructions.md for GitHub Copilot with PR review priorities and common issues to flag

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
CLAUDE.md Comprehensive development guide covering project architecture, coding conventions, encryption patterns, and testing guidelines
.github/instructions/jengine.instructions.md GitHub Copilot custom instructions for C# code generation with focus on UniTask, domain reload handling, and resource cleanup
.github/instructions/code-review.instructions.md GitHub Copilot review instructions highlighting priority checks for Unity-specific concerns and JEngine patterns

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@claude
Copy link

claude bot commented Jan 22, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@JasonXuDeveloper JasonXuDeveloper merged commit a8193ea into master Jan 22, 2026
11 checks passed
@JasonXuDeveloper JasonXuDeveloper deleted the add-ai-instructions branch January 22, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant