Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jans auth server client registration language metadata #1237

Merged
merged 20 commits into from
May 12, 2022
Merged

Jans auth server client registration language metadata #1237

merged 20 commits into from
May 12, 2022

Conversation

qbert2k
Copy link
Contributor

@qbert2k qbert2k commented Apr 20, 2022 •
edited by jmunozherbas
Loading

Prepare

Description

Target issue

#1057

Implementation Details

See #1057

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

qbert2k added 7 commits April 6, 2022 13:51
@qbert2k
feat(jans-auth-server): auth server should support client registratio…
5e592f8 
…n language metadata
@qbert2k
feat(jans-auth-server): auth server should support client registratio…
ebd1c5f 
…n language metadata

Signed-off-by: Javier Rojas Blum <javier.rojas.blum@gmail.com>
@qbert2k
Merge remote-tracking branch 'origin/main' into jans-auth-server-clie…
055e4df 
…nt-registration-language-metadata

# Conflicts:
#	jans-auth-server/model/src/main/java/io/jans/as/model/util/Util.java
#	jans-auth-server/server/src/main/java/io/jans/as/server/register/ws/rs/RegisterRestWebServiceImpl.java
@qbert2k
feat(jans-auth-server): auth server should support client registratio…
0af9229 
…n language metadata

Signed-off-by: Javier Rojas Blum <javier.rojas.blum@gmail.com>
@qbert2k
feat(jans-auth-server): auth server should support client registratio…
1699225 
…n language metadata
@qbert2k
Merge remote-tracking branch 'origin/main' into jans-auth-server-clie…
c3bca57 
…nt-registration-language-metadata
@qbert2k
Merge remote-tracking branch 'origin/main' into jans-auth-server-clie…
7313f96 
…nt-registration-language-metadata
@qbert2k qbert2k requested review from yurem and yuriyz as code owners April 20, 2022 22:36
@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR comp-jans-orm Component affected by issue or PR labels Apr 20, 2022
yuriyz
yuriyz requested changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@yuriyz yuriyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some improvements proposals, please check.

jans-orm/model/src/main/java/io/jans/orm/model/base/ClientMetadataValue.java Outdated Show resolved Hide resolved
jans-orm/model/src/test/java/io/jans/orm/model/base/ClientMetadataValueTest.java Outdated Show resolved Hide resolved
jans-auth-server/client/src/main/java/io/jans/as/client/RegisterRequest.java Outdated Show resolved Hide resolved
jans-auth-server/client/src/main/java/io/jans/as/client/RegisterRequest.java Outdated Show resolved Hide resolved
jans-auth-server/client/src/main/java/io/jans/as/client/RegisterRequest.java Outdated Show resolved Hide resolved
qbert2k added 4 commits April 25, 2022 17:20
@qbert2k
feat(jans-auth-server): auth server should support client registratio…
6612b1f 
…n language metadata
@qbert2k
feat(jans-auth-server): auth server should support client registratio…
7d603ba 
…n language metadata

Signed-off-by: Javier Rojas Blum <javier.rojas.blum@gmail.com>
@qbert2k
feat(jans-auth-server): auth server should support client registratio…
acf6bb3 
…n language metadata
@qbert2k
Merge remote-tracking branch 'origin/main' into jans-auth-server-clie…
82cdfd3 
…nt-registration-language-metadata

# Conflicts:
#	jans-auth-server/server/src/main/java/io/jans/as/server/register/ws/rs/RegisterService.java
@sonarqubecloud
Copy link

[notify] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

qbert2k added 4 commits April 26, 2022 21:13
@qbert2k
feat(jans-auth-server): auth server should support client registratio…
8dab44e 
…n language metadata

Signed-off-by: Javier Rojas Blum <javier.rojas.blum@gmail.com>
@qbert2k
feat(jans-auth-server): auth server should support client registratio…
17e5f78 
…n language metadata

Signed-off-by: Javier Rojas Blum <javier.rojas.blum@gmail.com>
@qbert2k
feat(jans-auth-server): auth server should support client registratio…
5a5ab46 
…n language metadata

Signed-off-by: Javier Rojas Blum <javier.rojas.blum@gmail.com>
@qbert2k
feat(jans-auth-server): auth server should support client registratio…
9af2ff1 
…n language metadata

fix sonar

Signed-off-by: Javier Rojas Blum <javier.rojas.blum@gmail.com>
@sonarqubecloud
Copy link

[orm] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

qbert2k added 3 commits April 26, 2022 22:29
@qbert2k
feat(jans-auth-server): auth server should support client registratio…
afb10f5 
…n language metadata

fix sonar:  remove unused imports

Signed-off-by: Javier Rojas Blum <javier.rojas.blum@gmail.com>
@qbert2k
Merge remote-tracking branch 'origin/main' into jans-auth-server-clie…
e15f106 
…nt-registration-language-metadata
@qbert2k
fix sonar: duplicated lines
6e2cd7b
@sonarqubecloud
Copy link

[jans-pycloudlib] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[jans-core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@qbert2k
Copy link
Contributor Author

qbert2k commented May 12, 2022 •
edited
Loading

Hi, @yuriyz
Regarding the sonar issues:

  1. The dupplicated lines of code are between Client.java and RegisterRequest.java (getters and setters) and because they are not related, I think hineritance is not a good solution. I am thinking to use Lombok, what do you think?
  2. There is annother compilation issue bloking the merge request. A compilation issue in jans-client-api but it seems not related to the changes in jans-auth-server.

@yuriyz
Copy link
Contributor

yuriyz commented May 12, 2022

Yes, I like lombok idea to reduce boilerplate code. Re: jans-client-api - ignore it. @jmunozherbas will correct it.

But if PR is ready we can let it go. Lets add lombok in separate PR. I don't want to put everything in one bucket. Duplicated lines is not end of the world. @qbert2k otherwise PR is ready, right ?

@sonarqubecloud
Copy link

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[Fido2 API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[SCIM API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[Jans authentication server parent] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
2.6% 2.6% Duplication

@qbert2k qbert2k requested a review from yuriyz May 12, 2022 20:17
@yuriyz yuriyz merged commit a8d0157 into main May 12, 2022
@yuriyz yuriyz deleted the jans-auth-server-client-registration-language-metadata branch May 12, 2022 21:22
This was referenced May 18, 2022
Merged
Merged
@mo-auto3 mo-auto3 mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
comp-jans-auth-server Component affected by issue or PR comp-jans-orm Component affected by issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qbert2k @yuriyz @mo-auto