Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stimulus triggered waveform display (Hantman Lab) #32

Closed
edkangdev opened this issue Apr 4, 2016 · 8 comments
Closed

Stimulus triggered waveform display (Hantman Lab) #32

edkangdev opened this issue Apr 4, 2016 · 8 comments

Comments

@edkangdev
Copy link
Collaborator

No description provided.

@edkangdev
Copy link
Collaborator Author

sync signal, clarify mode - is it similar to, or the same as gate mode? Or is gate mode a precondition for implementation?

@JaneliaAPIG
Copy link
Owner

JaneliaAPIG commented Apr 30, 2016

Austin Graves in Hantman lab requests this feature. It's a hybrid of the classic Waveform & Raster display modes. It's Waveform display mode, but with the selective display based on a (common) stimulus channel, rather than spike detection at each channel.

Since Raster mode already implements stimulus triggering, user implementation would use the same stimulus channel property that's specified for Raster mode.

@JaneliaAPIG JaneliaAPIG changed the title Sync Mode (needs more specification) Stimulus triggered waveform display (Hantman Lab) Apr 30, 2016
@JaneliaAPIG JaneliaAPIG added this to the 20160520 milestone Apr 30, 2016
@JaneliaAPIG
Copy link
Owner

JaneliaAPIG commented May 3, 2016

If stimulus is never detected, there will never be anything displayed. Only display the signal whenever the stimulus is detected.

@JaneliaAPIG
Copy link
Owner

This feature is basically no longer spike detection.

@vijayiyer05
Copy link
Collaborator

Appears fixed as of e283c9f

needs bench testing; also need to check to see if raster mode is still working after all the changes

@vijayiyer05
Copy link
Collaborator

vijayiyer05 commented Dec 28, 2016

Appears working as of cfe6344

  • Rig tested
  • Raster mode restored

@vijayiyer05
Copy link
Collaborator

vijayiyer05 commented Dec 30, 2016

Future issues discovered during work on this issue:

  • Issue 53
    ** This limits the max stimulus rate for a given timer period

  • Issue 55
    ** This can cause some stimuli to be missed, in rare cases. For r1.0, Spoke does not guarantee all stimuli are processed.

  • Issue 56

  • Issue 57

@vijayiyer05
Copy link
Collaborator

Rig demo uncovered a sporadic issue with stim-triggered waveform. Fixed as of fbf8107. Tested on rig.

Commit 2df4564 cleans up that fix in the code. Tested on bench, though not yet on rig. Presumed working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants