Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev doc/comments on waveformWrap/partialWaveformBuffer mechanism #56

Open
vijayiyer05 opened this issue Dec 30, 2016 · 0 comments
Open

Dev doc/comments on waveformWrap/partialWaveformBuffer mechanism #56

vijayiyer05 opened this issue Dec 30, 2016 · 0 comments
Labels
refactor/dev-driven

Comments

@vijayiyer05
Copy link
Collaborator

The waveformWrap/partialWaveformBuffer mechanism is used for stim-triggered waveform mode & could be useful for spike-triggered waveform mode.

My last review (@ a86807a) raised these questions:

  • What does this mechanism provide that augment/contract rawDataBuffer mechanism does not? Presumed answer: extending further than horizontalRange(2) into subsequent timer period if needed.

  • Reason for storing a list of waveformWrap and partialWaveformBufffer values per channel? How is this essential/enhancing to the waveform wrap capabilities?

  • Could this mechanism be applied to spike-triggered waveform mode? If so, would this obviate need for the augment/contract rawDataBuffer machinery?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor/dev-driven
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vijayiyer05