Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review spikeRefractoryPeriod user interface & implementation #57

Open
vijayiyer05 opened this issue Dec 31, 2016 · 0 comments
Open

Review spikeRefractoryPeriod user interface & implementation #57

vijayiyer05 opened this issue Dec 31, 2016 · 0 comments
Labels
refactor/dev-driven

Comments

@vijayiyer05
Copy link
Collaborator

A quick review of this property/functionality revealed some puzzles:

  • User-set property only has impact in raster mode. Should public property be renamed to rasterSpikeRefractoryPeriod?
  • There is no harm/impact to setting it in waveform mode. Should we allow it to be set? (esp. if it's renamed to rasterSpikeRefractoryPeriod)
  • Current behavior is for horizontalRange(2) to override the user-set property value in spike-triggered waveform mode. Does this make sense? Any reason not to allow a shorter value?
  • Current behavior appears to have no effect in stim-triggered waveform mode. Is this correct and as expected?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor/dev-driven
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vijayiyer05