-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically update fields in the database #2775
Comments
When trying to include all chunks that are a part of the
(The above should be fixed before completing this issue). Edit: Related to #2371 Note: There have been a lot of other PRs and issues on the topic of conflicting UIDs, most of them are closed though. This kind of problem stems from some constructors that override the term from a given chunk while inheriting the same UID from that chunk. Specifically, those constructors for But @balacij also pointed out that at that point, we are reducing a clear line of information to just a string for use in a UID and that using strings for UIDs may not be the best option. It could also be argued that we may also want to just keep these fields separate in the chunk database so they don't conflict. But it may be nice to refer to the term of a model-level chunk in a Sentence, so we may want the flexibility of combining the fields. Perhaps we shouldn't even allow different terms for the same UID in the first place. |
Good catch @Ant13731. You are correct that alpha_j is not the force. It is the angular acceleration. We should be clear that it is related to the rotational motion, not the translational motion. Can you change it to "alpha_j is the angular acceleration of the j-th body (rad/s^2)". Interestingly, the units were correct in the original; it is just the definition that is wrong. |
#2788 should be completed before uncommenting the functions that link between |
The basic idea is very good - the chunk hierarchy should indeed be used, instead of forcing the work onto the 'user'. I'm not so happy with the implementation scheme. I would prefer to teach Drasil about its own hierarchy, and thus have the lookup functions do the work automatically. That still leaves the issue of using the same UID for multiple things. In any single example, that should not be allowed at all.
That does indeed seem bad. I think I remember why: we're specializing from something generic to something more specific. Having a more specific term is good -- re-using the same UID is where things go wrong. |
Building off of #2675 and #2774, it might be nice to include all "complex" (or higher-level) chunks in their reduced forms for other fields of the chunk database. For example, everything that is in the
ConceptMap
field of aChunkDB
can be included under theTermMap
, since theConceptChunks
used in aConceptMap
containsIdeaDicts
which can be used in theTermMap
. This reduces the need for a user to include the same chunk in both fields.See #2675 for the original discussion on this issue.
The text was updated successfully, but these errors were encountered: