Remove as many RelationConcepts from the instance models as possible, by using ModelKind more

[JacquesCarette]

See f23bf7b for example. This is part of adding ModelKind to InstanceModel.

Basically, every instance model in all examples should be looked at, and either

1. its model should be changed from OthModel to something else (one per PR!)
2. an issue should be created regarding why it can't be done.

[balacij]

Trying to better keep track of them and their similarities:

Things not ticked off are still OthModels.

• Data.Drasil.Theories.Physics
  • newtonSL - Convert newtonSL into EquationalModel #2549 2549
  • weightGD - Convert weightGD into an EquationalModel #2537
  • hsPressureGD - Convert hsPressureGD into an EquationalModel #2538
  • newtonSLR - Convert Newton's SLRM TM into an EquationalModel #2539
  • accelerationTM - Convert AccelerationTM into an EquationalModel #2547
  • velocityTM - Convert velocityTM into an EquationalModel #2548
• DblPendulum
  • GenDefs
    • velocityIXGD - EquationalModel
    • velocityIYGD - EquationalModel
    • accelerationIXGD - EquationalModel
    • accelerationIYGD - EquationalModel
    • hForceOnPendulumGD - Convert DblPen's hForceOnPendulum into EquationalRealm #2590
    • vForceOnPendulumGD - Convert DblPen's GD vForceOnPendulum into EquationalRealm #2591
    • angFrequencyGD - Convert angFrequencyGD into an EquationalModel #2560
    • periodPend - Convert periodPendGD into EquationalModel #2561
  • IMods
    • angularDisplacementIM - Proto-Function definitions and function spaces, with a smaller example #2700
• GamePhysics
  • GenDefs
    • accelGravityGD - EquationalModel
    • impulseGD - EquationalModel
  • IMods
    • transMot - Convert GP's transMot IM into Equational model, moving the derivative… #2649
    • rotMot - Convert GP's rotMot IM into an EquationalModel #2663
    • col2D - Convert GP's col2D into a functional EquationalModel #2710
  • TMods
    • newtonSL - IMPORTED FROM Data.Drasil.Theories.Physics
    • newtonTL - EquationalModel
    • newtonLUG - RELATED TO Converting "Newton's law of universal gravitation" Theory Model #2436
    • newtonSLR - Convert GP's version of Newton's SLR into EquationalModel #2551
• GlassBR
  • IMods
    • pbIsSafe - RELATED TO Labels & GlassBR: Converting OthModels into EquationalModels #2388
    • lrIsSafe - Convert GlassBR's lrIsSafe IMod into an EquationalModel #2565
  • TMods
    • pbIsSafe - EquationalModel
    • lrIsSafe - EquationalModel
• HGHC
• NoPCM
  • GenDefs
    • rocTempSim -- IMPORTED FROM SWHS
    • htFluxWaterFromCoil - IMPORTED FROM SWHS
  • IMods
    • eBalanceOnWtr - Convert NoPCM IM eBalanceOnWtr into DEModel #2578
    • heatEInWtr - IMPORTED FROM SWHS
• PDController
  • GenDefs
    • gdPowerPlant - RELATED TO PDController: gdPowerPlant and tmSOSystem equations? #2446
  • IMods
    • imPD - DE Model - Convert PDController's single instance model into a DEModel #2573
  • TMods
    • tmLaplace - Function Model
    • tmInvLaplace - Function Model
    • tmSOSystem - RELATED TO PDController: gdPowerPlant and tmSOSystem equations? #2446
• Projectile
  • GenDefs
    • rectVelGD - RELATED TO Projectile's rectVelGD #2493
    • rectPosGD - EquationalModel
    • velVecGD - EquationalModel
    • posVecGD - EquationalModel
  • IMods
    • timeIM - EquationalModel - Convert Projectile's InstanceModels into EquationalModels #2569
    • landPosIM - EquationalModel - Convert Projectile's InstanceModels into EquationalModels #2569
    • offsetIM - EquationalModel - Convert Projectile's InstanceModels into EquationalModels #2569
    • messageIM - EquationalModel - Convert Projectile's InstanceModels into EquationalModels #2569
• SSP
  • GenDefs
    • normForcEqGD - inxi X $= Y model - PENDING Handling theories that define vectors #2587
    • bsShrFEqGD - inxi X $= Y model - PENDING Handling theories that define vectors #2587
    • resShrGD - inxi X $= Y model - PENDING Handling theories that define vectors #2587
    • mobShrGD - inxi X $= Y model - PENDING Handling theories that define vectors #2587
    • effNormFGD - inxi X $= Y model - PENDING Handling theories that define vectors #2587
    • resShearWOGD - inxi X $= Y model - PENDING Handling theories that define vectors #2587
    • mobShearWOGD - inxi X $= Y model - PENDING Handling theories that define vectors #2587
    • normShrRGD - Convert SSP's GenDefn normShrR into EquationalModel #2582
    • momentEqlGD - Convert SSP's GD:momentEql into EquationalConstraints model #2589
    • weightGD - inxi X $= Y model - PENDING Handling theories that define vectors #2587
    • sliceWghtGD - inxi X $= Y model - PENDING Handling theories that define vectors #2587
    • hsPressureGD - inxi X $= Y model - PENDING Handling theories that define vectors #2587
    • baseWtrFGD - inxi X $= Y model - PENDING Handling theories that define vectors #2587
    • srfWtrFGD - inxi X $= Y model - PENDING Handling theories that define vectors #2587
  • IMods
    • fctSfty - EquationalModel - Convert SSP IM fctSfty into EquationalModel #2605
    • nrmShrFor - Convert SSP's nrmShrFor into an EquationalModel #2674
    • nrmShrForNum - inxi X $= Y model - PENDING Handling theories that define vectors #2587
    • nrmShrForDen - inxi X $= Y model - PENDING Handling theories that define vectors #2587
    • intsliceFs - inxi X $= Y model - PENDING Handling theories that define vectors #2587
    • crtSlpId - Convert SSP's crtSlpId into an EquationalModel #2673
  • TMods
    • factOfSafety - EquationalModel
    • equilibrium - RELATED TO New ModelKind: EquilibriumModel? #2581
    • mcShrStrgth - Convert mcShrStrgth into EquationalModel #2558
    • effStress - Convert effStressTM into EquationalModel #2557
    • newtonSL - imported from Physics lib
• SWHS
  • GenDefs
    • rocTempSimp - DE Model - Convert SWHS GD rocTempSimp into DEModel #2577
    • htFluxWaterFromCoil - Convert htFluxWaterFromCoil GD into EquationalModel #2445 - EquationalModel - reorders references!
    • htFluxPCMFromWater - Convert SWHS htFluxPCMFromWater GD into EquationalModel #2444 - EquationalModel
  • IMods
    • eBalanceOnWtr - DE Model - Convert SWHS IM eBalanceOnWtr into DEModel #2574
    • eBalanceOnPCM - DE Model - Convert SWHS IM eBalanceOnPCM into DEModel #2575
    • heatEInWtr - Convert SWHS's heatEInWtr IM into a functional EquationalModel #2712
    • heatEInPCM - DE Model - Convert SWHS IM heatEInPCM into DEModel #2576
  • TMods
    • consThermE - Convert SWHS consThermE TM into EquationalConstraints model #2592
    • sensHtE - Convert SWHS sensHt TMod into EquationalModel #2443 - EquationalModel
    • latentHtE - Convert SWHS's latentHtE TM into a functional EquationalModel #2713
    • nwtnCooling - Convert SWHS's nwtnCoolingTM into a functional EquationalModel #2714

[balacij]

Note to self: Once all OthModels are converted into other things, we can easily implement MayHaveUnit of GenDefns in terms of the ModelKinds instead of having a separate field for it.

[balacij]

I don't remember where you (@JacquesCarette) mentioned it, but you previously mentioned that ModelKinds may need to be converted into a triple with a custom UID, NP (term), and the original ModelKind, and I think that with the last bunch of models, we will need that. Most of the existing converted ones only needed either a custom UID or term, so we added them to the models (IM/GD/TM) instead of the MK, but some of the last ones appear to need both.

I can see us changing ModelsKinds to something similar to:

type ModelKinds' = (ModelKinds, UID, NP)

or:

data ModelKinds' = MK' {
  _mk    :: ModelKinds,
  _mkUid :: UID,
  _mkNp  :: NP
}

The second variant is probably better.

[JacquesCarette]

Yes. As I've mentioned elsewhere, 4-tuples (and above): never. 3-tuples? rarely, and need strong justification.