Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDController: gdPowerPlant and tmSOSystem equations? #2446

Open
balacij opened this issue May 12, 2021 · 5 comments
Open

PDController: gdPowerPlant and tmSOSystem equations? #2446

balacij opened this issue May 12, 2021 · 5 comments
Assignees

Comments

@balacij
Copy link
Collaborator

balacij commented May 12, 2021

Related to #2371

Currently, these 2 chunks are not given any sort of "left-hand side" of their respective equations so I'm not quite sure what kind of a ModelKind model I should be creating for either of them.

image

image

@balacij
Copy link
Collaborator Author

balacij commented May 12, 2021

I hope it's okay that I assigned both of you @JacquesCarette and @smiths.

@balacij balacij changed the title PDController: gdPowerPlant and tmSOSystem PDController: gdPowerPlant and tmSOSystem equations? May 12, 2021
@JacquesCarette
Copy link
Owner

Yes, that's fine. In this case, I think it's going to be @smiths who needs to have first crack at it. Certainly these are not 'equations'. But what is the thing being defined here, I don't know.

@smiths
Copy link
Collaborator

smiths commented May 13, 2021

I can look at the example, but it might be a bit until I get to it. The PDController example hasn't really had a very detailed review to this point. (This example didn't come to us by the normal channels.) The equations will need to introduce a symbol for the transfer function, but I'll have to look to see if that symbol is used elsewhere or if we'll have to introduce it in multiple places.

@balacij
Copy link
Collaborator Author

balacij commented May 13, 2021

Thank you! That would be perfect. No rush, I have many tasks to work on in the mean time.

@balacij
Copy link
Collaborator Author

balacij commented Apr 27, 2023

I can give this a go too if you don't mind validating my work @smiths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants