-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDController: gdPowerPlant and tmSOSystem equations? #2446
Comments
I hope it's okay that I assigned both of you @JacquesCarette and @smiths. |
Yes, that's fine. In this case, I think it's going to be @smiths who needs to have first crack at it. Certainly these are not 'equations'. But what is the thing being defined here, I don't know. |
I can look at the example, but it might be a bit until I get to it. The PDController example hasn't really had a very detailed review to this point. (This example didn't come to us by the normal channels.) The equations will need to introduce a symbol for the transfer function, but I'll have to look to see if that symbol is used elsewhere or if we'll have to introduce it in multiple places. |
Thank you! That would be perfect. No rush, I have many tasks to work on in the mean time. |
I can give this a go too if you don't mind validating my work @smiths. |
Related to #2371
Currently, these 2 chunks are not given any sort of "left-hand side" of their respective equations so I'm not quite sure what kind of a ModelKind model I should be creating for either of them.
The text was updated successfully, but these errors were encountered: