forked from intel/llvm
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "[SYCL] Adds complex Literals support to sycl::experimental::c…
…omplex" (intel#10521) Reverts intel#9819 As mentioned in the PR intel#9867, this introduction of literal operators creates some issues due to literal operators receiving arguments as `long double` which are not supported on device code (and only works on host side); and our worries that users will try to use it and will not understand why it does not work. Also, user-defined literal operators should be declared with a `_` prefix to not clash with the standard literal operators when `using namespace std::literals`. Reverting this PR will facilitate the merge of the previously mentioned PR and have a place where the issues from this introduction are listed. Regardless of this PR, we'd still like to have support for literal operators for complex, so if you (@abagusetty) could open up a new PR for re-introducing the literal operator if a solution can be found also to handle it in device code, that would be great! @gmlueck @abagusetty
- Loading branch information
Showing
3 changed files
with
0 additions
and
60 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters