Revert "[SYCL] Adds complex Literals support to sycl::experimental::complex" #10521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffenlarsen
approved these changes
Jul 21, 2023
gmlueck
approved these changes
Jul 21, 2023
|
Precommit failure seems to be an infrastructure hiccup. |
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
…omplex" (intel#10521) Reverts intel#9819 As mentioned in the PR intel#9867, this introduction of literal operators creates some issues due to literal operators receiving arguments as `long double` which are not supported on device code (and only works on host side); and our worries that users will try to use it and will not understand why it does not work. Also, user-defined literal operators should be declared with a `_` prefix to not clash with the standard literal operators when `using namespace std::literals`. Reverting this PR will facilitate the merge of the previously mentioned PR and have a place where the issues from this introduction are listed. Regardless of this PR, we'd still like to have support for literal operators for complex, so if you (@abagusetty) could open up a new PR for re-introducing the literal operator if a solution can be found also to handle it in device code, that would be great! @gmlueck @abagusetty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9819
As mentioned in the PR #9867, this introduction of literal operators creates some issues due to literal operators receiving arguments as
long doublewhich are not supported on device code (and only works on host side); and our worries that users will try to use it and will not understand why it does not work.Also, user-defined literal operators should be declared with a
_prefix to not clash with the standard literal operators whenusing namespace std::literals.Reverting this PR will facilitate the merge of the previously mentioned PR and have a place where the issues from this introduction are listed.
Regardless of this PR, we'd still like to have support for literal operators for complex, so if you (@abagusetty) could open up a new PR for re-introducing the literal operator if a solution can be found also to handle it in device code, that would be great!
@gmlueck @abagusetty