Allow basic markup syntax custom previews #6232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add MarkdownFormatter using https://github.com/vsch/flexmark-java/ to format markdown. To configure Markdown in custom previews add the "Markdown" formatter. Markdown is enabled by default for the comment field as requested in JabRef#6194
…urnsOnlyOneLine to actually test newlines only because the rest is covered elsewhere
koppor
added
the
status: ready-for-review
tobiasdiez
requested changes
Apr 2, 2020
Member
tobiasdiez
left a comment
tobiasdiez
left a comment
There was a problem hiding this comment.
Welcome to the world of open-source! I'm impressed by your first PR. The code looks mostly good to me and I've only a few minor comments.
One bigger suggestion: Right now the article description (title author etc) takes quite some space in the preview. I would thus suggest to replace the article preview in the comment tab by a html rendering of only the content of the comment field.
koppor
removed
the
status: ready-for-review
…ations as well as suggested in review by @tobiasdiez and @koppor
Member
|
Needed to merge Could you fix CheckStyle? |
…thub.com/AlexanderGirgis/jabref into allow-basic-markup-in-comment-fixes-6194
koppor
approved these changes
Apr 3, 2020
koppor
pushed a commit
that referenced
this pull request
Oct 1, 2022
7bde3e4 Add style for the Geographical Analysis journal (#6145) 6fa1551 Create taylor-and-francis-chicago-b-author-date.csl (#6232) eba2e8c Create taylor-and-francis-ama.csl (#6221) dda9d57 ACS, AMA, Vancouver: Remove hardcoded space after `citation-number` (#6248) 8f5fe92 GitHub Workflows security hardening (#6246) 284bc10 Create angiology.csl (#6122) eb141cc Update society-of-biblical-literature-fullnote-bibliography.csl (#6157) dddb459 Rewrite law-citation-manual.csl (#6171) (#6171) b975c96 Update Cell to numeric-superscript style (#6245) 3a41b08 Create isara-iso-690.csl (#6201) 5a128fe Create Biomembranes.csl (#6200) da2e0c0 Capitalize-first short titles for legislation ("Statute"). (#6241) af7f08d Create proceedings-of-the-estonian-academy-of-sciences-author-date.csl (#6209) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 7bde3e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MarkdownFormatter using https://github.com/vsch/flexmark-java/ to format markdown.
To configure Markdown in custom previews add the "Markdown" formatter.
Markdown is enabled by default for the comment field as requested in #6194
Fixes #6194