Skip to content

Conversation

@tobiasdiez
Copy link
Member

@tobiasdiez tobiasdiez commented Mar 18, 2020

Have to wait until Gradle 6.3 is released (which should be next week) due to gradle/gradle#10248.
Apart from this issue, this PR is now ready for review.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for bigger UI changes)
  • Checked documentation: Is the information available and up to date? If not: Issue created at https://github.com/JabRef/user-documentation/issues.

@tobiasdiez tobiasdiez changed the title Update to JDK 14 [WIP] Update to JDK 14 Mar 18, 2020
@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 18, 2020
@tobiasdiez tobiasdiez requested a review from koppor March 18, 2020 22:52
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could start without issues. Like that we do not need to download jpackage manually.

@tobiasdiez
Copy link
Member Author

I'll merge now as the deployment action is broken due to missing jpackage.

@tobiasdiez tobiasdiez merged commit 23b0064 into master Mar 20, 2020
@tobiasdiez tobiasdiez deleted the jdk14 branch March 20, 2020 13:15
@koppor koppor changed the title [WIP] Update to JDK 14 Update to JDK 14 Mar 20, 2020
koppor pushed a commit that referenced this pull request Oct 1, 2022
7bde3e4 Add style for the Geographical Analysis journal (#6145)
6fa1551 Create taylor-and-francis-chicago-b-author-date.csl (#6232)
eba2e8c Create taylor-and-francis-ama.csl (#6221)
dda9d57 ACS, AMA, Vancouver: Remove hardcoded space after `citation-number` (#6248)
8f5fe92 GitHub Workflows security hardening (#6246)
284bc10 Create angiology.csl (#6122)
eb141cc Update society-of-biblical-literature-fullnote-bibliography.csl (#6157)
dddb459 Rewrite law-citation-manual.csl (#6171) (#6171)
b975c96 Update Cell to numeric-superscript style (#6245)
3a41b08 Create isara-iso-690.csl (#6201)
5a128fe Create Biomembranes.csl (#6200)
da2e0c0 Capitalize-first short titles for legislation ("Statute"). (#6241)
af7f08d Create proceedings-of-the-estonian-academy-of-sciences-author-date.csl (#6209)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 7bde3e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants