Skip to content

New Crowdin translations #4090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 4, 2018
Merged

New Crowdin translations #4090

merged 18 commits into from
Jun 4, 2018

Conversation

Siedlerchr
Copy link
Member

Enjoy!

@koppor
Copy link
Member

koppor commented Jun 4, 2018

@tobiasdiez Do the deleted/added strings sound reasonable to you? I assume, we have to replace the & by _, don't we? (Refs https://stackoverflow.com/a/24500058/873282)

@tobiasdiez
Copy link
Member

Yes, the changes look reasonable to me. JavaFX does not use & or _ to signal the hotkey and thus there shouldn't be any longer text that use them for this purpose. The translations still run through our own parsing engine, so I'm not sure how to properly encode &.

@koppor koppor merged commit bec15f4 into master Jun 4, 2018
@koppor koppor deleted the l10n_master branch June 4, 2018 13:31
@koppor
Copy link
Member

koppor commented Jun 4, 2018

According to https://stackoverflow.com/a/24500058/873282, the _ can be used to signal the letter used for the Alt key, can't it?

grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants